[browsershots-factories] Re: Testing shotfactory under windows
Johann C. Rocholl
johann at browsershots.org
Thu Aug 24 14:54:58 CEST 2006
On 8/24/06, Marcin Król <hawk at limanowa.net> wrote:
> > 1. There is no os.spawnlp under windows so browser command is not enough
> > to launch browser. Full path is also needed (and it may be different on
> > each factory). For now I've hardcoded my path into windows.py, but thats
> > probably not acceptable.
>
> The best workaround here would be to put full path as command in
> database for windows browsers. Johann, can you put following commands
> for my factory so I could implement and test required code changes?
>
> c:\bin\kmeleon.bat
> c:\bin\msie.bat
> c:\bin\netscape4.bat
> c:\bin\netscape6.bat
> c:\bin\netscape7.bat
> c:\bin\netscape8.bat
I don't want to put the full path name into the database because then
a hacked server could run any command on your machine, and has the
smell of a serious security problem to me.
Maybe the factory could add the c:\bin\ prefix? Alternatively, why
don't we put those scripts in the same directory where the factory is
being run, or in the existing subdirectory "scripts" (where the
shotfactory script lives)?
> For scrolling we need to know class name of browser window. Since this
> information differs from browser to browser IMO it should be put into
> database. X11 and Darwin may simply ignore this field. Johann, if you
> will agree for that here are class names for my browsers:
>
> K-Meleon
> KMeleon Browser Window
>
> MSIE
> IEFrame
>
> Netscape 4
> Afx:400000:b:14be:6:d7f
>
> Netscape 6 and 7
> MozillaWindowClass
>
> Netscape 8
> NS_AE_WindowClass
This is a very good idea. This way it's very easy to add new browsers
later. I'll add it to the database and send the window name to the
shotfactory with a new key in the config dict.
J.
More information about the browsershots-factories
mailing list